Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bugs related to state resolution #2507

Merged
merged 11 commits into from
Jun 1, 2022
Merged

Fix bugs related to state resolution #2507

merged 11 commits into from
Jun 1, 2022

Conversation

neilalexander
Copy link
Contributor

@neilalexander neilalexander commented May 31, 2022 •
edited
Loading

This should hopefully fix a bunch of seemingly random state corruption issues that were happening.

Should fix #2503, fix #2465, fix #2129.

kegsay
kegsay reviewed May 31, 2022
View reviewed changes
Copy link
Member

@kegsay kegsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this works the way you want it to without any tests. Probably ok?

roomserver/state/state.go Outdated Show resolved Hide resolved
@neilalexander neilalexander marked this pull request as ready for review June 1, 2022 08:39
@neilalexander neilalexander requested a review from a team as a code owner June 1, 2022 08:39
@neilalexander neilalexander merged commit 3d9fe20 into main Jun 1, 2022
@neilalexander neilalexander deleted the neilalexander/fixstateres branch June 1, 2022 08:46
@neilalexander neilalexander mentioned this pull request Jun 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kegsay kegsay kegsay left review comments

Assignees
No one assigned
Labels
C-Roomserver
Projects
None yet
Milestone
No milestone
2 participants
@neilalexander @kegsay